Summary: | Clean up RenderWidget::destroy() to share more code | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bdakin, jamesr, mitz, simon.fraser, tony | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2011-07-07 17:42:13 PDT
Created attachment 100185 [details]
Patch
Comment on attachment 100185 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100185&action=review Looks great, just one question. > Source/WebCore/rendering/RenderWidget.cpp:-142 > - if (hasOverrideSize()) > - setOverrideSize(-1); this is different from what RenderBox::destroy() did, it did: gOverrideSizeMap->remove(this) are these equivalent? Almost: void RenderBox::setOverrideSize(int s) { if (s == -1) { if (hasOverrideSize()) { setHasOverrideSize(false); gOverrideSizeMap->remove(this); } I'll change RenderBox::willBeDestroyed() to call setOverrideSize(-1); Created attachment 100189 [details]
Patch
Comment on attachment 100189 [details]
Patch
Transferring r+ from jamesr. New patch for the bots to chew on.
|