Summary: | Move innerTextElement() from RenderTextControl to HTMLTextFormControlHTMLTextFormControlElement | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
Component: | Forms | Assignee: | Ryosuke Niwa <rniwa> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | adele, ap, darin, dglazkov, inferno, mjs, tkent | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 64133 | ||||||
Bug Blocks: | 47865, 60403 | ||||||
Attachments: |
|
Description
Ryosuke Niwa
2011-07-07 16:52:18 PDT
Created attachment 100167 [details]
Patch
Comment on attachment 100167 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100167&action=review > Source/WebCore/ChangeLog:14 > + shadow DOM for input and textarea elements clear. It accessing shadow DOM of input and textarea elements > + are now less error-prone because it doesn't depend on the lifetime of the render tree. Oops, typo. It should read "Accessing the shadow DOM of input and textarea elements are now less error prone because it no longer depends on the lifetime of the render tree". Comment on attachment 100167 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100167&action=review > Source/WebCore/rendering/RenderTextControl.h:56 > + HTMLElement* innerTextElement() const; Let's add a comment that this function should not be public. Otherwise, one who doesn't know the intention of this patch might make it public and revert the AccessibilityRenderObject.cpp change. Comment on attachment 100167 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100167&action=review >> Source/WebCore/rendering/RenderTextControl.h:56 >> + HTMLElement* innerTextElement() const; > > Let's add a comment that this function should not be public. > Otherwise, one who doesn't know the intention of this patch might make it public and revert the AccessibilityRenderObject.cpp change. That makes sense. Committed r90775: <http://trac.webkit.org/changeset/90775> |