Bug 64134

Summary: Move innerTextElement() from RenderTextControl to HTMLTextFormControlHTMLTextFormControlElement
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: FormsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: adele, ap, darin, dglazkov, inferno, mjs, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 64133    
Bug Blocks: 47865, 60403    
Attachments:
Description Flags
Patch tkent: review+, tkent: commit-queue-

Ryosuke Niwa
Reported 2011-07-07 16:52:18 PDT
Now that shadow DOM no longer hangs off of renderer, it seems more natural for HTMLTextFormControl instead of RenderTextControl to have inner*Element().
Attachments
Patch (14.12 KB, patch)
2011-07-08 15:07 PDT, Ryosuke Niwa 		tkent: review+
tkent: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-07-08 15:07:14 PDT
Created attachment 100167 [details] Patch
Ryosuke Niwa
Comment 2 2011-07-08 15:08:57 PDT
Comment on attachment 100167 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100167&action=review > Source/WebCore/ChangeLog:14 > + shadow DOM for input and textarea elements clear. It accessing shadow DOM of input and textarea elements > + are now less error-prone because it doesn't depend on the lifetime of the render tree. Oops, typo. It should read "Accessing the shadow DOM of input and textarea elements are now less error prone because it no longer depends on the lifetime of the render tree".
Kent Tamura
Comment 3 2011-07-08 16:44:12 PDT
Comment on attachment 100167 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100167&action=review > Source/WebCore/rendering/RenderTextControl.h:56 > + HTMLElement* innerTextElement() const; Let's add a comment that this function should not be public. Otherwise, one who doesn't know the intention of this patch might make it public and revert the AccessibilityRenderObject.cpp change.
Ryosuke Niwa
Comment 4 2011-07-08 16:47:44 PDT
Comment on attachment 100167 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100167&action=review >> Source/WebCore/rendering/RenderTextControl.h:56 >> + HTMLElement* innerTextElement() const; > > Let's add a comment that this function should not be public. > Otherwise, one who doesn't know the intention of this patch might make it public and revert the AccessibilityRenderObject.cpp change. That makes sense.
Ryosuke Niwa
Comment 5 2011-07-08 16:48:20 PDT
Now that r90662 has been reverted, I'd have to reland the patch for the bug 64133 first.
Ryosuke Niwa
Comment 6 2011-07-11 12:06:40 PDT
Committed r90775: <http://trac.webkit.org/changeset/90775>
Note You need to log in before you can comment on or make changes to this bug.