Summary: | Move all code related to cachedSelection to HTMLTextFormControlElement | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
Component: | Forms | Assignee: | Ryosuke Niwa <rniwa> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | adele, ap, darin, dglazkov, eric, mjs, ojan, sam, tkent | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 47865, 60403 | ||||||
Attachments: |
|
Description
Ryosuke Niwa
2011-07-07 12:21:58 PDT
Created attachment 100020 [details]
Removed lots of code
Ping reviewers because I have a lot of cleanups to do and this patch is blocking my work. Comment on attachment 100020 [details] Removed lots of code View in context: https://bugs.webkit.org/attachment.cgi?id=100020&action=review > Source/WebCore/html/HTMLFormControlElement.cpp:715 > + if (!renderer() || !isTextFormControl()) When is HTMLTextFormControlElement not a text form control? > Source/WebCore/html/HTMLFormControlElement.h:238 > + int m_cachedSelectionStart; > + int m_cachedSelectionEnd; What prevents these from being private? Comment on attachment 100020 [details] Removed lots of code View in context: https://bugs.webkit.org/attachment.cgi?id=100020&action=review Thanks for the review! >> Source/WebCore/html/HTMLFormControlElement.cpp:715 >> + if (!renderer() || !isTextFormControl()) > > When is HTMLTextFormControlElement not a text form control? input[type=checkbox], input[type=radio], etc... >> Source/WebCore/html/HTMLFormControlElement.h:238 >> + int m_cachedSelectionEnd; > > What prevents these from being private? Oh, right. Will make them private. I had to make them protected when HTMLInputElement and HTMLTextAreaElement still access those variables directly. (In reply to comment #4) > >> Source/WebCore/html/HTMLFormControlElement.cpp:715 > >> + if (!renderer() || !isTextFormControl()) > > > > When is HTMLTextFormControlElement not a text form control? > > input[type=checkbox], input[type=radio], etc... I agree that it's very confusing and we should probably rename it to isTextField. Committed r90591: <http://trac.webkit.org/changeset/90591> |