Bug 64091

Summary: [GTK] [NRWT] Pixel tests do not work
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: Tools / TestsAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
Patch none

Martin Robinson
Reported 2011-07-07 08:23:08 PDT
Pixel tests do not work for NRWT because _path_to_image_diff is unimplemented in the gtk.py.
Attachments
Patch (1.39 KB, patch)
2011-07-07 08:25 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2011-07-07 08:25:48 PDT
Created attachment 99983 [details] Patch
Eric Seidel (no email)
Comment 2 2011-07-07 10:15:48 PDT
Comment on attachment 99983 [details] Patch Yay! Ideally we would test this. But there may not be much to test here.
WebKit Review Bot
Comment 3 2011-07-07 10:57:44 PDT
Comment on attachment 99983 [details] Patch Rejecting attachment 99983 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2 Last 500 characters of output: 39b7cc200e948da1d67bca0f143dd0a54453d3a8 r90578 = 5352a4e441505abbb6835baf39b948e6d76c11ff Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/8991648
Martin Robinson
Comment 4 2011-07-11 15:29:29 PDT
Comment on attachment 99983 [details] Patch Clearing flags on attachment: 99983 Committed r90786: <http://trac.webkit.org/changeset/90786>
Martin Robinson
Comment 5 2011-07-11 15:29:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.