Bug 64091 - [GTK] [NRWT] Pixel tests do not work
Summary: [GTK] [NRWT] Pixel tests do not work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-07 08:23 PDT by Martin Robinson
Modified: 2011-07-11 15:29 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.39 KB, patch)
2011-07-07 08:25 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2011-07-07 08:23:08 PDT
Pixel tests do not work for NRWT because _path_to_image_diff is unimplemented in the gtk.py.
Comment 1 Martin Robinson 2011-07-07 08:25:48 PDT
Created attachment 99983 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-07-07 10:15:48 PDT
Comment on attachment 99983 [details]
Patch

Yay!  Ideally we would test this.  But there may not be much to test here.
Comment 3 WebKit Review Bot 2011-07-07 10:57:44 PDT
Comment on attachment 99983 [details]
Patch

Rejecting attachment 99983 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2

Last 500 characters of output:
39b7cc200e948da1d67bca0f143dd0a54453d3a8
r90578 = 5352a4e441505abbb6835baf39b948e6d76c11ff
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Updating chromium port dependencies using gclient...

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/8991648
Comment 4 Martin Robinson 2011-07-11 15:29:29 PDT
Comment on attachment 99983 [details]
Patch

Clearing flags on attachment: 99983

Committed r90786: <http://trac.webkit.org/changeset/90786>
Comment 5 Martin Robinson 2011-07-11 15:29:33 PDT
All reviewed patches have been landed.  Closing bug.