Summary: | Move remaining enums out of SVG*Element classes | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> | ||||
Component: | SVG | Assignee: | Nikolas Zimmermann <zimmermann> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | zimmermann | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Nikolas Zimmermann
2011-07-07 01:56:46 PDT
Created attachment 99960 [details] Patch Splitted up from bug 63797. Comment on attachment 99960 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99960&action=review r=me. Not sure if you should remove the comment about forward declaration or add it to all elements. Up to you: > Source/WebCore/svg/SVGTextContentElement.h:75 > + // Forward declare these enums in the w3c naming scheme, for IDL generation I wounder why you did not add this comment on the other enums like for SVGMarker or SVGGradient?!? (In reply to comment #2) > (From update of attachment 99960 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=99960&action=review > > r=me. Not sure if you should remove the comment about forward declaration or add it to all elements. Up to you: > > > Source/WebCore/svg/SVGTextContentElement.h:75 > > + // Forward declare these enums in the w3c naming scheme, for IDL generation > > I wounder why you did not add this comment on the other enums like for SVGMarker or SVGGradient?!? Just forgot it. Fixed. Landed in r90560. |