Bug 64066

Summary:

DFG JIT does not implement op_construct

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	none
the patch (fix style)	none
the patch	barraclough: review-, barraclough: commit-queue-
the patch (fix review)	none

Filip Pizlo

Reported 2011-07-06 23:48:27 PDT

The DFG JIT does not implement the op_construct opcode. This means that code containing object construction will not get compiled with DFG. DFG JIT should implement op_construct.

Attachments
the patch (20.89 KB, patch) 2011-07-06 23:51 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (fix style) (20.88 KB, patch) 2011-07-07 00:02 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (22.38 KB, patch) 2011-07-12 16:22 PDT, Filip Pizlo	barraclough: review- barraclough: commit-queue-	Details Formatted Diff Diff
the patch (fix review) (25.73 KB, patch) 2011-07-12 17:13 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2011-07-06 23:51:18 PDT

Created attachment 99946 [details] the patch

WebKit Review Bot

Comment 2 2011-07-06 23:53:52 PDT

Attachment 99946 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/dfg/DFGRepatch.h:40: The parameter name "kind" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 3 2011-07-07 00:02:46 PDT

Created attachment 99948 [details] the patch (fix style)

WebKit Review Bot

Comment 4 2011-07-07 16:55:09 PDT

Comment on attachment 99948 [details] the patch (fix style) Clearing flags on attachment: 99948 Committed r90602: <http://trac.webkit.org/changeset/90602>

WebKit Review Bot

Comment 5 2011-07-07 16:55:13 PDT

All reviewed patches have been landed. Closing bug.

Gavin Barraclough

Comment 6 2011-07-08 16:43:49 PDT

Reopening - these changes were rolled out in r90673 due to https://bugs.webkit.org/show_bug.cgi?id=64181

Filip Pizlo

Comment 7 2011-07-12 16:22:05 PDT

Created attachment 100583 [details] the patch This patch fixes two bugs in the previous patch, which, together with other patches since committed, makes this work with gmail, bankrate, facebook, reddit, and google (according to my testing), even with DFG restrictions turned off.

Gavin Barraclough

Comment 8 2011-07-12 16:38:08 PDT

Comment on attachment 100583 [details] the patch Hey Filip, following on from our conversation earlier, looking at the two bugs this fixes since the original patch, one looks tougher to test for (error on unlinking calls), but the other does look testable (virtualFor always compiles for call). To test we'd just have to have one function use new, call another, and have the constructor that is called do something that would prove whether it was invoked as a call or a constructor (as an example, returning a non-object value would do). Unless there is any reason it won't be possible, let's add a LayoutTest.

Filip Pizlo

Comment 9 2011-07-12 17:13:55 PDT

Created attachment 100592 [details] the patch (fix review)

WebKit Review Bot

Comment 10 2011-07-12 18:46:22 PDT

Comment on attachment 100592 [details] the patch (fix review) Clearing flags on attachment: 100592 Committed r90877: <http://trac.webkit.org/changeset/90877>

WebKit Review Bot

Comment 11 2011-07-12 18:46:27 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.