Summary: | Split Driver, DriverOutput and DriverInput out into a new driver.py file | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dpranke, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Eric Seidel (no email)
2011-07-06 14:13:28 PDT
Created attachment 99878 [details]
Patch
Comment on attachment 99878 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99878&action=review > Tools/Scripts/webkitpy/layout_tests/port/__init__.py:37 > -from test import unit_test_filesystem > +import builders # Why is this in port? > > -import builders > +from base import Port # It's possible we don't need to export this virtual baseclass outside the module. > +from driver import Driver, DriverInput, DriverOutput We've had pain importing things in __init__ files before. Maybe this will be ok though... Comment on attachment 99878 [details] Patch Rejecting attachment 99878 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 2 Last 500 characters of output: ls/Scripts/webkitpy/layout_tests/port/test.py patching file Tools/Scripts/webkitpy/layout_tests/port/webkit.py patching file Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py patching file Tools/Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py patching file Tools/Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/8986884 Committed r90506: <http://trac.webkit.org/changeset/90506> |