Bug 64027

Summary: garden-o-matic should use a favicon to indicate current state.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: New BugsAssignee: Dimitri Glazkov (Google) <dglazkov>
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch abarth: review+, abarth: commit-queue-

Description Dimitri Glazkov (Google) 2011-07-06 13:42:29 PDT
garden-o-matic should use a favicon to indicate current state.
Comment 1 Dimitri Glazkov (Google) 2011-07-06 13:44:01 PDT
Created attachment 99873 [details]
Comment 2 Adam Barth 2011-07-06 13:49:39 PDT
Comment on attachment 99873 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=99873&action=review

> Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:48
> +<link rel=icon id=favicon type=image/png href=favicon-green.png>

pls use " around attribute values.

> Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:18
> +    document.getElementById('favicon').href = 'favicon-' + (hasFailures ? 'red' : 'green') + '.png';

I was thinking we'd use jQuery to interact with the DOM:

var faviconURL = 'favicon-' + (hasFailures ? 'red' : 'green') + '.png';
$('#favicon').attr('href', faviconURL);

I'm not sure it really matters, but just to be consistent.
Comment 3 Dimitri Glazkov (Google) 2011-07-06 14:10:57 PDT
Committed r90496: <http://trac.webkit.org/changeset/90496>