Summary: | garden-o-matic should use a favicon to indicate current state. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dimitri Glazkov (Google) <dglazkov> | ||||
Component: | New Bugs | Assignee: | Dimitri Glazkov (Google) <dglazkov> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Dimitri Glazkov (Google)
2011-07-06 13:42:29 PDT
Created attachment 99873 [details]
Patch
Comment on attachment 99873 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99873&action=review > Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:48 > +<link rel=icon id=favicon type=image/png href=favicon-green.png> pls use " around attribute values. > Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:18 > + document.getElementById('favicon').href = 'favicon-' + (hasFailures ? 'red' : 'green') + '.png'; I was thinking we'd use jQuery to interact with the DOM: var faviconURL = 'favicon-' + (hasFailures ? 'red' : 'green') + '.png'; $('#favicon').attr('href', faviconURL); I'm not sure it really matters, but just to be consistent. Committed r90496: <http://trac.webkit.org/changeset/90496> |