Bug 64023

Summary: DFG JIT op_call implementation will flush registers even when those registers are dead
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch none

Filip Pizlo
Reported 2011-07-06 13:10:42 PDT
The DFG JIT op_call implementation invokes flushRegisters() to ensure that any live registers are spilled and later refilled on-demand, since in our calling convention all registers are caller-save. However, in the current implementation flushRegisters() may also flush registers that are killed by the call.
Attachments
the patch (8.89 KB, patch)
2011-07-06 13:29 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2011-07-06 13:29:26 PDT
Created attachment 99870 [details] the patch
WebKit Review Bot
Comment 2 2011-07-06 14:40:25 PDT
Comment on attachment 99870 [details] the patch Clearing flags on attachment: 99870 Committed r90502: <http://trac.webkit.org/changeset/90502>
WebKit Review Bot
Comment 3 2011-07-06 14:40:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.