Bug 64022

Summary: DFG speculative JIT contains a FIXME for rewinding speculative code generation that has already been fixed
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch none

Filip Pizlo
Reported 2011-07-06 13:07:53 PDT
The DFG speculative JIT may perform a speculation that turns out to be statically false. In this case, speculative code generation is rolled back. Despite the fact that this feature is already implemented, there is still a FIXME in DFGSpeculativeJIT.h that indicates that we should implement this already-implemented feature. Additionally, the same code path also generates a speculation check despite the fact that any code generated by this path will be rewound.
Attachments
the patch (1.38 KB, patch)
2011-07-06 13:49 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2011-07-06 13:49:34 PDT
Created attachment 99875 [details] the patch
WebKit Review Bot
Comment 2 2011-07-14 12:31:36 PDT
Comment on attachment 99875 [details] the patch Clearing flags on attachment: 99875 Committed r91022: <http://trac.webkit.org/changeset/91022>
WebKit Review Bot
Comment 3 2011-07-14 12:31:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.