Bug 64009

Summary: [chromium] Add compositor texture manager soft limits and lost focus reclaiming
Product: WebKit Reporter: Adrienne Walker <enne>
Component: New BugsAssignee: Adrienne Walker <enne>
Status: RESOLVED FIXED    
Severity: Normal CC: enne, jamesr, nduca, vangelis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch jamesr: review+

Description Adrienne Walker 2011-07-06 11:28:35 PDT
[chromium] Add compositor texture manager soft limits and lost focus reclaiming
Comment 1 Adrienne Walker 2011-07-06 11:33:24 PDT
Created attachment 99855 [details]
Patch
Comment 2 James Robinson 2011-07-06 13:27:07 PDT
Comment on attachment 99855 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99855&action=review

Looks good.

> Source/WebCore/platform/graphics/chromium/TextureManager.h:66
> +    bool reduceMemoryToLimit(size_t);

the return value is never used, can you change it to be void?
Comment 3 Adrienne Walker 2011-07-06 13:34:34 PDT
(In reply to comment #2)
> (From update of attachment 99855 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=99855&action=review
>
> > Source/WebCore/platform/graphics/chromium/TextureManager.h:66
> > +    bool reduceMemoryToLimit(size_t);
> 
> the return value is never used, can you change it to be void?

Good catch.  Can do.
Comment 4 Adrienne Walker 2011-07-06 15:33:36 PDT
Committed r90505: <http://trac.webkit.org/changeset/90505>