Bug 63999

Summary: Web Inspector: Add support for clearing cache and cookies from network panel.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, mathias, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch pfeldman: review+, webkit.review.bot: commit-queue-

Description Vsevolod Vlasov 2011-07-06 08:57:48 PDT 
Add support for clearing cache and cookies from network panel.
Comment 1 Vsevolod Vlasov 2011-07-06 10:05:17 PDT 
Created attachment 99848 [details]
Patch
Comment 2 WebKit Review Bot 2011-07-06 10:14:12 PDT 
Comment on attachment 99848 [details]
Patch

Attachment 99848 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/8995070
Comment 3 Pavel Feldman 2011-07-07 00:02:21 PDT 
Comment on attachment 99848 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99848&action=review

r+ with nits.

> LayoutTests/http/tests/inspector/network/network-clear-cookies.html-disabled:14
> +    internals.setInspectorResourcesDataSizeLimits(document, 10 * 1000 * 1000, 1000 * 1000);

This should be a part of the network-test.js

> Source/WebCore/inspector/InspectorClient.h:55
> +    virtual void clearBrowserCache() { };

nuke ;

> Source/WebCore/inspector/InspectorResourceAgent.cpp:478
> +void InspectorResourceAgent::clearBrowserCache(ErrorString* errorString)

Mac build failed with unused errorString

> Source/WebCore/inspector/InspectorResourceAgent.cpp:483
> +void InspectorResourceAgent::clearBrowserCookies(ErrorString* errorString)

ditto

> Source/WebKit/chromium/public/WebDevToolsAgentClient.h:62
> +    virtual void clearBrowserCache() { };

nuke ;
Comment 4 Vsevolod Vlasov 2011-07-07 03:47:28 PDT 
Committed r90553: <http://trac.webkit.org/changeset/90553>
Comment 5 Vsevolod Vlasov 2011-07-07 03:48:52 PDT 
Fixed nits except for this one.

> > LayoutTests/http/tests/inspector/network/network-clear-cookies.html-disabled:14
> > +    internals.setInspectorResourcesDataSizeLimits(document, 10 * 1000 * 1000, 1000 * 1000);
> 
> This should be a part of the network-test.js
I'll deal with it here https://bugs.webkit.org/show_bug.cgi?id=64078