Bug 63995

Summary:

[Qt] [WK2] Add touch mocking to Qt's Minibrowser

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

Tools / Tests

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

Qt, QtTriaged

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kling: review+, kling: commit-queue-

Description Benjamin Poulain 2011-07-06 08:26:49 PDT

Minibrowser is unusable with the touch view on desktop because the platform does not send any touch event.
We should create fake touch events for mouse events.

Comment 1 Benjamin Poulain 2011-07-06 08:58:06 PDT

Created attachment 99839 [details]
Patch

Comment 2 Andreas Kling 2011-07-06 09:33:00 PDT

Comment on attachment 99839 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99839&action=review

r=me with some kennethisms

> Tools/ChangeLog:3
> +        [Qt] [WK2] Add touch mocking to Qt's Minibrowser

MiniBrowser!!!111twotwotwo

> Tools/ChangeLog:8
> +        The mouse event are intercepted through QCoreApplication::notify(),

event -> events

> Tools/MiniBrowser/qt/MiniBrowserApplication.cpp:83
> +    /* We try to be smart, if we received real touch event, we are probably on a device
> +       with touch screen, and we should not have touch mocking */

// comments, please!

Comment 3 Benjamin Poulain 2011-07-06 12:35:43 PDT

I just noticed I forgot to close this bug at work...

This has landed: http://trac.webkit.org/changeset/90475