Bug 63983

Summary: new-run-webkit-tests uses a 35s timeout for Mac and 6s for all other ports
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 34984    
Attachments:
Description Flags
Patch
none
Patch xan.lopez: review+, xan.lopez: commit-queue+

Eric Seidel (no email)
Reported 2011-07-06 03:21:07 PDT
new-run-webkit-tests uses a 35s timeout for Mac and 6s for all other ports
Attachments
Patch (4.04 KB, patch)
2011-07-06 03:22 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch (4.34 KB, patch)
2011-07-06 03:24 PDT, Eric Seidel (no email) 		xan.lopez: review+
xan.lopez: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-07-06 03:22:39 PDT
Created attachment 99806 [details] Patch
Eric Seidel (no email)
Comment 2 2011-07-06 03:23:25 PDT
The check that MacPort.__init__ was using was wrong, because the option is called time_out_ms, not time-out-ms. It didn't matter unless someone tried to override the timeout value.
Eric Seidel (no email)
Comment 3 2011-07-06 03:24:38 PDT
Created attachment 99808 [details] Patch
Xan Lopez
Comment 4 2011-07-06 03:26:49 PDT
Comment on attachment 99808 [details] Patch Excellent!
Eric Seidel (no email)
Comment 5 2011-07-06 03:28:30 PDT
Committed r90448: <http://trac.webkit.org/changeset/90448>
Note You need to log in before you can comment on or make changes to this bug.