Summary: | [EFL] Add Fullscreen API feature | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||
Component: | WebKit EFL | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Gyuyoung Kim
2011-07-05 21:31:57 PDT
Created attachment 99789 [details]
Patch
From what I understood, if one sets ENABLE_FULLSCREEN_API to ON, the build will fail or things will not work later, right? If so, I prefer to hold this commit until the missing implementation enters the tree. > ChangeLog:6 > + Reviewed by NOBODY (OOPS!). More details are welcome here: if you still need to work on the code as you mentioned in the bug report, explain here that this commit only adds the flags and files to the build system. > Source/WebCore/CMakeLists.txt:1410 > + ${WEBCORE_DIR}/css/fullscreen.css Not sorted alphabetically. > Source/cmake/OptionsEfl.cmake:76 > +WEBKIT_FEATURE(ENABLE_FULLSCREEN_API "Enable the Fullscreen API support" DEFAULT OFF) "the" not needed Created attachment 99829 [details] Modified Patch I fix this patch according to your comments. >> if one sets ENABLE_FULLSCREEN_API to ON, the build will fail or things will not work later, right? If so, I prefer to hold this commit until the missing implementation enters the tree. If RenderFullScreen.cpp is missed when this feature is enabled on current version, build error happens. So, though ENABLE_FULLSCREEN_API is turned on, there is no build break on this patch . I'd like to implement remained missing things step by step after landing this patch. As long as enabling fullscreen support after this patch enters the tree does not break the build, r+ from my side. Comment on attachment 99829 [details] Modified Patch Clearing flags on attachment: 99829 Committed r90531: <http://trac.webkit.org/changeset/90531> All reviewed patches have been landed. Closing bug. |