Bug 63974

Summary:

DFG JIT virtual call implementation is inefficient

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	none

Description Filip Pizlo 2011-07-05 21:25:41 PDT

When making a virtual call, only one check is necessary to see if the function needs to be compiled.  Currently, the code does two checks (first, if it's a host, and second, if it needs to be compiled).  The old JIT folded both checks into a query on the number of parameters (which would be negative if the function was neither a host function nor was compiled).  The DFG JIT should have the same optimization.

Comment 1 Filip Pizlo 2011-07-05 21:52:09 PDT

Created attachment 99790 [details]
the patch

Comment 2 WebKit Review Bot 2011-07-05 23:35:56 PDT

Comment on attachment 99790 [details]
the patch

Clearing flags on attachment: 99790

Committed r90437: <http://trac.webkit.org/changeset/90437>

Comment 3 WebKit Review Bot 2011-07-05 23:36:00 PDT

All reviewed patches have been landed.  Closing bug.