Bug 63943

Summary: Spelling error in v8WebSocket::constructorCallback error
Product: WebKit Reporter: Berend-Jan Wever <skylined>
Component: DOMAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows Vista   
Attachments:
Description Flags
Patch
none
Patch none

Berend-Jan Wever
Reported 2011-07-05 09:08:29 PDT
Adam, I think you misspelled "constructor": WebKit/Source/WebCore/bindings/v8/custom/V8WebSocketCustom.cpp@53: return throwError("DOM object custructor cannot be called as a function."); Repro/test: <script> try { WebSocket() } catch(e) { document.write(e.message.indexOf('custructor') == -1 ? 'PASS' : 'FAIL:' + e.message);} </script>
Attachments
Patch (1.94 KB, patch)
2011-10-13 16:18 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (3.17 KB, patch)
2011-10-13 16:20 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-10-13 16:18:43 PDT
Created attachment 110922 [details] Patch
Adam Barth
Comment 2 2011-10-13 16:20:02 PDT
Created attachment 110924 [details] Patch
WebKit Review Bot
Comment 3 2011-10-13 22:11:40 PDT
Comment on attachment 110924 [details] Patch Clearing flags on attachment: 110924 Committed r97441: <http://trac.webkit.org/changeset/97441>
WebKit Review Bot
Comment 4 2011-10-13 22:11:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.