Bug 63943

Summary:

Spelling error in v8WebSocket::constructorCallback error

Product:

WebKit

Reporter:

Berend-Jan Wever <skylined>

Component:

DOM

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows Vista

Attachments:

Description	Flags
Patch	none
Patch	none

Description Berend-Jan Wever 2011-07-05 09:08:29 PDT

Adam, I think you misspelled "constructor":

WebKit/Source/WebCore/bindings/v8/custom/V8WebSocketCustom.cpp@53:
        return throwError("DOM object custructor cannot be called as a function.");

Repro/test:
<script>
  try { WebSocket() } catch(e) { document.write(e.message.indexOf('custructor') == -1 ? 'PASS' : 'FAIL:' + e.message);}
</script>

Comment 1 Adam Barth 2011-10-13 16:18:43 PDT

Created attachment 110922 [details]
Patch

Comment 2 Adam Barth 2011-10-13 16:20:02 PDT

Created attachment 110924 [details]
Patch

Comment 3 WebKit Review Bot 2011-10-13 22:11:40 PDT

Comment on attachment 110924 [details]
Patch

Clearing flags on attachment: 110924

Committed r97441: <http://trac.webkit.org/changeset/97441>

Comment 4 WebKit Review Bot 2011-10-13 22:11:44 PDT

All reviewed patches have been landed.  Closing bug.