Bug 63932 – Web Inspector: add "element state" setting to the styles section title.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Pavel Feldman]

This is a part of the support for the :hover, :active, etc.

[Pavel Feldman]

Created attachment 99706 [details]
[IMAGE] Draft icon for :active/:hover/:focus toggle.

[Pavel Feldman]

Created attachment 99714 [details]
[IMAGE] Looks with patch applied.

[Pavel Feldman]

Created attachment 99715 [details]
Patch

[Alexander Pavlov (apavlov)]

Comment on attachment 99715 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99715&action=review

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:58
> +    var muteEventListener = function(event) { event.stopPropagation(); event.preventDefault(); };

Any point in having this as a standalone var?

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:722
> +        var tr = document.createElement("tr");

a good shortcut:
var tr = table.createChild("tr");
(also appends tr to table)

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:727
> +        tr = document.createElement("tr");

ditto

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:732
> +        this._elementStatePane.appendChild(table);

you could potentially use the same approach for table

> Source/WebCore/inspector/front-end/inspector.css:1775
> +

odd new blank line

> Source/WebCore/inspector/front-end/inspector.css:4556
> +    border-spacing: 0;

You don't need this property here as it applies to tables only

> Source/WebCore/inspector/front-end/inspector.css:4567
> +

extra blank line

[Pavel Feldman]

Committed r90397: <http://trac.webkit.org/changeset/90397>