Bug 63925

Summary: [V8][Chromium] Remove use of OwnHandle from V8LocalContext
Product: WebKit Reporter: Hans Wennborg <hans>
Component: New BugsAssignee: Hans Wennborg <hans>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dslomov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Hans Wennborg
Reported 2011-07-05 01:17:32 PDT
[V8][Chromium] Remove use of OwnHandle from V8LocalContext
Attachments
Patch (2.47 KB, patch)
2011-07-05 01:22 PDT, Hans Wennborg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hans Wennborg
Comment 1 2011-07-05 01:22:44 PDT
Created attachment 99677 [details] Patch
Hans Wennborg
Comment 2 2011-07-05 01:24:51 PDT
Uploaded as per the discussion in Bug 62345.
Dmitry Lomov
Comment 3 2011-07-05 11:36:35 PDT
(In reply to comment #2) > Uploaded as per the discussion in Bug 62345. LGTM. Just to note, it is still unclear why OwnHandle does not do the job - I will investigate this more. > Source/WebCore/bindings/v8/V8Utilities.cpp:52 > + : m_context(v8::Context::New()) It does not matter one bit currently, but logically we want to do any V8 operations (including newing up the context) after we ensure that V8BindingPerIsolateData is initialized.
Adam Barth
Comment 4 2011-07-05 14:47:37 PDT
> It does not matter one bit currently, but logically we want to do any V8 operations (including newing up the context) after we ensure that V8BindingPerIsolateData is initialized. So you're saying we shouldn't do this in the initializer list?
WebKit Review Bot
Comment 5 2011-07-05 15:13:55 PDT
Comment on attachment 99677 [details] Patch Clearing flags on attachment: 99677 Committed r90407: <http://trac.webkit.org/changeset/90407>
WebKit Review Bot
Comment 6 2011-07-05 15:13:59 PDT
All reviewed patches have been landed. Closing bug.
Dmitry Lomov
Comment 7 2011-07-05 15:18:54 PDT
(In reply to comment #4) > > It does not matter one bit currently, but logically we want to do any V8 operations (including newing up the context) after we ensure that V8BindingPerIsolateData is initialized. > > So you're saying we shouldn't do this in the initializer list? In the Grand Scheme Of Things (TM), yes, but it does not matter as of today.
Note You need to log in before you can comment on or make changes to this bug.