| Summary: | NP_RemoveProperty is not called back by Safari when delete npObject.prop is encountered in JavaScript | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
| Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | kbalazs, zherczeg | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Anders Carlsson
2011-07-04 12:48:45 PDT
Created attachment 99650 [details]
Patch
Committed r90372: <http://trac.webkit.org/changeset/90372> Killed the Qt bot: /ramdisk/qt-linux-release/build/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp: In member function ‘bool NPRuntimeRemoveProperty::TestObject::getProperty(void*, NPVariant*)’: /ramdisk/qt-linux-release/build/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:64: error: ‘strlen’ was not declared in this scope /ramdisk/qt-linux-release/build/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:64: error: too many initializers for ‘NPString’ Probably #include <string.h> could solve this. Are you aware of this? (In reply to comment #3) > Are you aware of this? Fixed in http://trac.webkit.org/changeset/90374. Let me quote a half sentence from the Changelog: "... there doesn't seem to be a way to make a WebKit2 specific test." This could be fixed by adding wk2 specific results to the Layouttests/platform/wk2 directory and teach owrt and nwrt to use them. I created a bug for this: https://bugs.webkit.org/show_bug.cgi?id=63926 |