Bug 63909

Summary: Remove virtual functions from StyleImage.
Product: WebKit Reporter: Tamas Czene <tczene>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: ap, koivisto, loki, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Remove virtual functions from StyleImage
none
Remove virtual functions from StyleImage none

Tamas Czene
Reported 2011-07-04 07:53:20 PDT
We can remove the virtual "isChachedImage, isPendingImage, isGeneratedImage" functions to speed up the StyleImage part of WebKit. Some profile data shows this part is significant, especially in small CSS-based sites. Removing the virtual functions - removing the calls - makes a small performance progression on this part. We measured around 1% speed up on several sites like: bing.com , youtube.com
Attachments
Remove virtual functions from StyleImage (5.42 KB, patch)
2011-07-04 08:13 PDT, Tamas Czene 		no flags
DetailsFormatted DiffDiff
Remove virtual functions from StyleImage (5.45 KB, patch)
2011-07-05 01:10 PDT, Tamas Czene 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tamas Czene
Comment 1 2011-07-04 08:13:12 PDT
Created attachment 99632 [details] Remove virtual functions from StyleImage
Tamas Czene
Comment 2 2011-07-05 01:10:48 PDT
Created attachment 99675 [details] Remove virtual functions from StyleImage
Simon Fraser (smfr)
Comment 3 2011-07-05 08:09:04 PDT
Comment on attachment 99675 [details] Remove virtual functions from StyleImage View in context: https://bugs.webkit.org/attachment.cgi?id=99675&action=review > Source/WebCore/ChangeLog:10 > + Some profile data shows this part is significant, especially in small CSS-based sites. > + Removing the virtual functions - removing the calls - makes a small performance progression on this part. You should put more information in the bug about your performance investigations. What sites did you test? What as the measured gain? What stack traces show time in these methods?
WebKit Review Bot
Comment 4 2011-07-05 09:07:47 PDT
Comment on attachment 99675 [details] Remove virtual functions from StyleImage Clearing flags on attachment: 99675 Committed r90399: <http://trac.webkit.org/changeset/90399>
WebKit Review Bot
Comment 5 2011-07-05 09:07:52 PDT
All reviewed patches have been landed. Closing bug.
Tamas Czene
Comment 6 2011-07-07 04:18:25 PDT
Generally the effect of the patch is only measurable on small sites. Examples (Methanol results): bing.com 2,6% wordpress.org 5,7%
Note You need to log in before you can comment on or make changes to this bug.