Bug 63900

Summary: [Qt] Fix Qt5 build
Product: WebKit Reporter: Peter Varga <pvarga>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: abecsi, benjamin, hausmann, peter.hartmann, robert
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
proposed patch
none
proposed patch v1.1 hausmann: review-, hausmann: commit-queue-

Peter Varga
Reported 2011-07-04 05:39:21 PDT
The compiling of QtWebKit with qtbase-staging (git://gitorious.org/+qt-developers/qt/qtbase-staging.git) fails since this change: http://trac.webkit.org/changeset/90341 It seems the QUrl::topLevelDomain() function hasn't been added to the Qt-5 version. I think we should change the guards in the QtWebKit to allow the "third-party cookie stuff" just in case of using Qt-4.8 while the QURL::topLevelDomain() is missing from the Qt-5.
Attachments
proposed patch (10.23 KB, patch)
2011-07-04 05:43 PDT, Peter Varga 		no flags
DetailsFormatted DiffDiff
proposed patch v1.1 (10.23 KB, patch)
2011-07-04 05:58 PDT, Peter Varga 		hausmann: review-
hausmann: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Peter Varga
Comment 1 2011-07-04 05:43:57 PDT
Created attachment 99615 [details] proposed patch
Peter Varga
Comment 2 2011-07-04 05:58:14 PDT
Created attachment 99618 [details] proposed patch v1.1 Fix ChangeLog.
Simon Hausmann
Comment 3 2011-07-04 06:01:31 PDT
Hang on, Peter is merging the change from Qt 4.8 to qtbase-staging
Simon Hausmann
Comment 4 2011-07-04 06:11:33 PDT
Hmm, topLevelDomain() is in qtbase: https://qt.gitorious.org/qt/qtbase/blobs/master/src/corelib/io/qurl.h#line185
Simon Hausmann
Comment 5 2011-07-04 06:18:20 PDT
Comment on attachment 99618 [details] proposed patch v1.1 Conclusion: qtbase-staging is obsolete, use qtbase.git :)
Simon Hausmann
Comment 6 2011-07-05 01:25:32 PDT
House keeping :)
Note You need to log in before you can comment on or make changes to this bug.