Bug 63867

Summary: Move the plug-in controller member variable up to the shared Plugin base class
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Anders Carlsson
Reported 2011-07-02 16:27:57 PDT
Move the plug-in controller member variable up to the shared Plugin base class
Attachments
Patch (22.06 KB, patch)
2011-07-02 16:32 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-07-02 16:32:32 PDT
Created attachment 99563 [details] Patch
Sam Weinig
Comment 2 2011-07-02 16:36:42 PDT
Comment on attachment 99563 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99563&action=review > Source/WebKit2/WebProcess/Plugins/Plugin.h:81 > + virtual bool initialize(const Parameters&) = 0; Can this be private? It seems likes only the two parameter version should ever be called directly.
Anders Carlsson
Comment 3 2011-07-02 16:40:36 PDT
Committed r90326: <http://trac.webkit.org/changeset/90326>
Note You need to log in before you can comment on or make changes to this bug.