Bug 63867 - Move the plug-in controller member variable up to the shared Plugin base class
Summary: Move the plug-in controller member variable up to the shared Plugin base class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-02 16:27 PDT by Anders Carlsson
Modified: 2011-07-02 16:40 PDT (History)
0 users

See Also:

Attachments
Patch (22.06 KB, patch)
2011-07-02 16:32 PDT, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-07-02 16:27:57 PDT 
Move the plug-in controller member variable up to the shared Plugin base class
Comment 1 Anders Carlsson 2011-07-02 16:32:32 PDT 
Created attachment 99563 [details]
Patch
Comment 2 Sam Weinig 2011-07-02 16:36:42 PDT 
Comment on attachment 99563 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99563&action=review

> Source/WebKit2/WebProcess/Plugins/Plugin.h:81
> +    virtual bool initialize(const Parameters&) = 0;

Can this be private? It seems likes only the two parameter version should ever be called directly.
Comment 3 Anders Carlsson 2011-07-02 16:40:36 PDT 
Committed r90326: <http://trac.webkit.org/changeset/90326>