Bug 63866

Summary: DFG JIT - implement instanceof
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
The patch sam: review+

Gavin Barraclough
Reported 2011-07-02 15:32:02 PDT
Add ops CheckHasInstance & InstanceOf to implement bytecodes op_check_has_instance & op_instanceof.
Attachments
The patch (15.51 KB, patch)
2011-07-02 15:36 PDT, Gavin Barraclough 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2011-07-02 15:36:02 PDT
Created attachment 99562 [details] The patch
WebKit Review Bot
Comment 2 2011-07-02 15:37:15 PDT
Attachment 99562 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/dfg/DFGJITCompiler.h:225: Missing space inside { }. [whitespace/braces] [5] Source/JavaScriptCore/dfg/DFGOperations.h:64: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gavin Barraclough
Comment 3 2011-07-02 16:08:39 PDT
Fixed in r90324.
Note You need to log in before you can comment on or make changes to this bug.