Bug 63865

Summary: SVGAnimatedPath needs fallback for 'by' animation
Product: WebKit Reporter: Dirk Schulze <krit>
Component: SVGAssignee: Dirk Schulze <krit>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 41761    
Attachments:
Description Flags
Patch rwlbuis: review+

Description Dirk Schulze 2011-07-02 13:38:26 PDT
SVGAnimatedPath needs fallback for 'by' animation.
Comment 1 Dirk Schulze 2011-07-02 13:52:30 PDT
Created attachment 99559 [details]
Patch
Comment 2 WebKit Review Bot 2011-07-02 13:54:53 PDT
Attachment 99559 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/svg/..." exit_code: 1

Source/WebCore/svg/SVGAnimatedPath.cpp:72:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedPath.cpp:72:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Rob Buis 2011-07-07 10:15:57 PDT
Comment on attachment 99559 [details]
Patch

LGTM
Comment 4 Dirk Schulze 2011-07-07 11:44:05 PDT
Committed r90582: <http://trac.webkit.org/changeset/90582>