Summary: | SVGAnimatedPath needs fallback for 'by' animation | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dirk Schulze <krit> | ||||
Component: | SVG | Assignee: | Dirk Schulze <krit> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | webkit.review.bot, zimmermann | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 41761 | ||||||
Attachments: |
|
Description
Dirk Schulze
2011-07-02 13:38:26 PDT
Created attachment 99559 [details]
Patch
Attachment 99559 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/svg/..." exit_code: 1
Source/WebCore/svg/SVGAnimatedPath.cpp:72: The parameter type should use PassOwnPtr instead of OwnPtr. [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedPath.cpp:72: The parameter type should use PassOwnPtr instead of OwnPtr. [readability/pass_ptr] [5]
Total errors found: 2 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 99559 [details]
Patch
LGTM
Committed r90582: <http://trac.webkit.org/changeset/90582> |