Bug 63848

Summary: Consider backing scale when setting up graphics layers
Product: WebKit Reporter: Darin Adler <darin>
Component: Layout and RenderingAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Darin Adler
Reported 2011-07-01 14:29:19 PDT
Consider backing scale factor when setting up graphics layers
Attachments
Patch (8.77 KB, patch)
2011-07-01 14:34 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (9.24 KB, patch)
2011-07-01 16:09 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2011-07-01 14:34:12 PDT
Created attachment 99524 [details] Patch
Darin Adler
Comment 2 2011-07-01 14:34:53 PDT
<rdar://problem/8669917>
Simon Fraser (smfr)
Comment 3 2011-07-01 14:42:08 PDT
Comment on attachment 99524 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99524&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:111 > + ASSERT(renderer()); > + ASSERT(renderer()->document()); > + ASSERT(renderer()->document()->frame()); Should these be moved to pageContentsScale()? > Source/WebCore/rendering/RenderLayerBacking.h:195 > + float pageContentsScale() const; Why not just call this pageScaleFactor() to avoid introducing another term?
Darin Adler
Comment 4 2011-07-01 14:55:28 PDT
Comment on attachment 99524 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99524&action=review >> Source/WebCore/rendering/RenderLayerBacking.cpp:111 >> + ASSERT(renderer()->document()->frame()); > > Should these be moved to pageContentsScale()? Probably not. At other call sites it may be OK for some of these things to be null. >> Source/WebCore/rendering/RenderLayerBacking.h:195 >> + float pageContentsScale() const; > > Why not just call this pageScaleFactor() to avoid introducing another term? Will do.
Darin Adler
Comment 5 2011-07-01 16:09:19 PDT
Created attachment 99534 [details] Patch
Darin Adler
Comment 6 2011-07-01 16:13:32 PDT
Committed r90293: <http://trac.webkit.org/changeset/90293>
Note You need to log in before you can comment on or make changes to this bug.