Bug 63831

Summary:

[Qt] Fix build when --media-stream flag is used

Product:

WebKit

Reporter:

Danilo de Paula <danilo.eu>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ademar, igor.oliveira, webkit.review.bot

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
diff adding the new rule on features.pri	none
mediastreamflag.patch	none
mediastream.patch	none

Danilo de Paula

Reported 2011-07-01 12:32:27 PDT

Fixing Qt port build when media-stream flag is enabled.

Attachments
diff adding the new rule on features.pri (1.94 KB, patch) 2011-07-01 12:33 PDT, Danilo de Paula	no flags	Details Formatted Diff Diff
mediastreamflag.patch (1.99 KB, patch) 2011-07-01 12:40 PDT, Danilo de Paula	no flags	Details Formatted Diff Diff
mediastream.patch (1.96 KB, patch) 2011-07-01 14:06 PDT, Danilo de Paula	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Danilo de Paula

Comment 1 2011-07-01 12:33:54 PDT

Created attachment 99505 [details] diff adding the new rule on features.pri Forgot the patch

WebKit Review Bot

Comment 2 2011-07-01 12:36:22 PDT

Attachment 99505 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Danilo de Paula

Comment 3 2011-07-01 12:40:48 PDT

Created attachment 99507 [details] mediastreamflag.patch

Igor Trindade Oliveira

Comment 4 2011-07-01 13:02:33 PDT

You should remove the "No new tests" line because Commit Bot can complain. And add [Qt] tag in the beginning of commit title. (In reply to comment #3) > Created an attachment (id=99507) [details] > mediastreamflag.patch

Ademar Reis

Comment 5 2011-07-01 13:13:21 PDT

from build-webkit --help: --[no-]media-stream Toggle Media Stream API support (implies Blob support, currently Chromium and GTK only) (default: 0) Do you get anything useful on Qt with --media-stream? If yes, then maybe your patch should also remove this note from build-webkit.

Danilo de Paula

Comment 6 2011-07-01 14:06:14 PDT

Created attachment 99519 [details] mediastream.patch Fixing commit message.

WebKit Review Bot

Comment 7 2011-07-04 03:55:37 PDT

The commit-queue encountered the following flaky tests while processing attachment 99519 [details]: http/tests/local/blob/send-sliced-data-blob.html bug 63598 (author: kinuko@chromium.org) The commit-queue is continuing to process your patch.

WebKit Review Bot

Comment 8 2011-07-04 03:57:00 PDT

Comment on attachment 99519 [details] mediastream.patch Clearing flags on attachment: 99519 Committed r90359: <http://trac.webkit.org/changeset/90359>

WebKit Review Bot

Comment 9 2011-07-04 03:57:04 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.