Summary: | [Qt] Fix build when --media-stream flag is used | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Danilo de Paula <danilo.eu> | ||||||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ademar, igor.oliveira, webkit.review.bot | ||||||||
Priority: | P2 | Keywords: | Qt | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Danilo de Paula
2011-07-01 12:32:27 PDT
Created attachment 99505 [details]
diff adding the new rule on features.pri
Forgot the patch
Attachment 99505 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 99507 [details]
mediastreamflag.patch
You should remove the "No new tests" line because Commit Bot can complain. And add [Qt] tag in the beginning of commit title. (In reply to comment #3) > Created an attachment (id=99507) [details] > mediastreamflag.patch from build-webkit --help: --[no-]media-stream Toggle Media Stream API support (implies Blob support, currently Chromium and GTK only) (default: 0) Do you get anything useful on Qt with --media-stream? If yes, then maybe your patch should also remove this note from build-webkit. Created attachment 99519 [details]
mediastream.patch
Fixing commit message.
The commit-queue encountered the following flaky tests while processing attachment 99519 [details]: http/tests/local/blob/send-sliced-data-blob.html bug 63598 (author: kinuko@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 99519 [details] mediastream.patch Clearing flags on attachment: 99519 Committed r90359: <http://trac.webkit.org/changeset/90359> All reviewed patches have been landed. Closing bug. |