Bug 63815

Summary: REGRESSION (r90229): webkit-patch rollout and sheriffbot rollout are broken
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, dbates, dpranke, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dbates: review+

Description Adam Roben (:aroben) 2011-07-01 09:36:59 PDT
REGRESSION (r90229): webkit-patch rollout and sheriffbot rollout are broken
Comment 1 Adam Roben (:aroben) 2011-07-01 09:40:01 PDT
Created attachment 99483 [details]
Patch
Comment 2 Daniel Bates 2011-07-01 09:50:49 PDT
Comment on attachment 99483 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99483&action=review

> Tools/Scripts/webkitpy/common/checkout/changelog.py:181
>      def update_with_unreviewed_message(self, message):

Should we rename this method?
Comment 3 Adam Roben (:aroben) 2011-07-01 09:53:09 PDT
Comment on attachment 99483 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99483&action=review

>> Tools/Scripts/webkitpy/common/checkout/changelog.py:181
>>      def update_with_unreviewed_message(self, message):
> 
> Should we rename this method?

The name isn't that great, but it's no worse than it was before. We could probably come up with a better one.
Comment 4 Adam Roben (:aroben) 2011-07-01 09:55:02 PDT
Committed r90239: <http://trac.webkit.org/changeset/90239>
Comment 5 Eric Seidel (no email) 2011-07-01 11:23:01 PDT
Did you check for any other code in ChagneLogs.py which might need updating?
Comment 6 Adam Roben (:aroben) 2011-07-01 12:02:24 PDT
(In reply to comment #5)
> Did you check for any other code in ChagneLogs.py which might need updating?

I just checked now and I don't think there's anything else that needs to be changed.