Bug 63804

Summary:

commit-log-editor reorders ChangeLog entries in unexpected ways

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, dbates, ddkilzer

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

URL:

http://trac.webkit.org/log/trunk

Attachments:

Description	Flags
commit-log-editor reorders ChangeLog entries in unexpected ways	darin: review+

Adam Roben (:aroben)

Reported 2011-07-01 07:29:25 PDT

In bug 27754, commit-log-editor was changed to reorder ChangeLog entries to try to get the bug title and URL to be at the top of the commit message. This was intended to make commit messages be more git-friendly. (Lots of git tools expect a one-line summary of the change at the top of the commit message.) This reordering is somewhat surprising, and the conditions under which it is performed are hard to determine. This leads to a surprising experience for users. I think it would be much better if we just changed the template prepare-ChangeLog uses to put the bug title and URL at the top of the ChangeLog. Then commit-log-editor wouldn't have to do any reordering.

Attachments
commit-log-editor reorders ChangeLog entries in unexpected ways (5.52 KB, patch) 2011-07-01 08:11 PDT, Adam Roben (:aroben)	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Roben (:aroben)

Comment 1 2011-07-01 08:11:58 PDT

Created attachment 99472 [details] commit-log-editor reorders ChangeLog entries in unexpected ways

Adam Roben (:aroben)

Comment 2 2011-07-01 08:21:29 PDT

Committed r90229: <http://trac.webkit.org/changeset/90229>

Note You need to log in before you can comment on or make changes to this bug.