Bug 63764

Summary: Added empty write barrier stubs in all the right places in the DFG JIT
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch barraclough: review+

Geoffrey Garen
Reported 2011-06-30 16:00:04 PDT
Added empty write barrier stubs in all the right places in the DFG JIT
Attachments
Patch (13.54 KB, patch)
2011-06-30 16:04 PDT, Geoffrey Garen 		barraclough: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2011-06-30 16:04:29 PDT
Created attachment 99386 [details] Patch
Gavin Barraclough
Comment 2 2011-06-30 16:43:18 PDT
Comment on attachment 99386 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99386&action=review > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:-1086 > - m_jit.loadPtr(globalObject->addressOfRegisters(), temp.gpr()); Maybe addressOfRegisters can go away?
Geoffrey Garen
Comment 3 2011-06-30 17:08:18 PDT
> Maybe addressOfRegisters can go away? Alas, alack, it's still used in some places, but I was able to deploy JSVariableObject::offsetOfRegisters() in more places.
Geoffrey Garen
Comment 4 2011-06-30 17:10:28 PDT
Committed r90187: <http://trac.webkit.org/changeset/90187>
Note You need to log in before you can comment on or make changes to this bug.