Bug 63763

Summary: new-run-webkit-tests should stop when I ^C it
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dpranke: review+, abarth: commit-queue+

Adam Barth
Reported 2011-06-30 15:51:55 PDT
new-run-webkit-tests should stop when I ^C it
Attachments
Patch (2.21 KB, patch)
2011-06-30 15:53 PDT, Adam Barth 		dpranke: review+
abarth: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-06-30 15:53:23 PDT
Created attachment 99383 [details] Patch
Dirk Pranke
Comment 2 2011-06-30 16:00:25 PDT
Comment on attachment 99383 [details] Patch Ah! I'd been meaning to figure out why that had regressed. Thanks for fixing this.
Dirk Pranke
Comment 3 2011-06-30 16:02:48 PDT
Oh, as to the "not fast enough" comment ... I agree that it's slow, but much of that slowness is in trying to make sure everything gets cleaned up properly. On some platforms it appears that the child processes don't always get killed themselves by the ctrl-C. I don't know how much actual room for improvement there may be (in the sense that I literally have no idea, not that I think I had previously done the best possible job).
Adam Barth
Comment 4 2011-06-30 16:05:28 PDT
Comment on attachment 99383 [details] Patch Yeah, I don't have any ideas for making it faster. Just that it should be faster. :)
Adam Barth
Comment 5 2011-06-30 16:07:20 PDT
Committed r90176: <http://trac.webkit.org/changeset/90176>
Note You need to log in before you can comment on or make changes to this bug.