| Summary: | WebSocket: Don't use old Hixie75 handshake in pywebsocket handlers | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yuta Kitamura <yutak> | ||||
| Component: | Tools / Tests | Assignee: | Yuta Kitamura <yutak> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, ap, tkent, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 62795 | ||||||
| Attachments: |
|
||||||
|
Description
Yuta Kitamura
2011-06-30 05:39:21 PDT
Created attachment 99282 [details]
Patch
Comment on attachment 99282 [details]
Patch
Why have the existing tests worked with the older handshake?
The commit-queue encountered the following flaky tests while processing attachment 99282 [details]: http/tests/local/blob/send-sliced-data-blob.html bug 63598 (author: kinuko@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 99282 [details] Patch Clearing flags on attachment: 99282 Committed r90196: <http://trac.webkit.org/changeset/90196> All reviewed patches have been landed. Closing bug. (In reply to comment #2) > (From update of attachment 99282 [details]) > Why have the existing tests worked with the older handshake? The tests fail before WebSocketChannel checks handshake format of server's response. So they worked regardless of the handshake format. There is no reason to leave the older handshake in tests, so I wrote this patch. Thank you for your review! I should have said "the tests finish" instead of "the tests fail". (Failing the connection is expected result for these tests.) |