Bug 63704 - WebSocket: Don't use old Hixie75 handshake in pywebsocket handlers
Summary: WebSocket: Don't use old Hixie75 handshake in pywebsocket handlers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yuta Kitamura
URL:
Keywords:
Depends on:
Blocks: 62795
  Show dependency treegraph
 
Reported: 2011-06-30 05:39 PDT by Yuta Kitamura
Modified: 2011-07-01 01:17 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.58 KB, patch)
2011-06-30 06:13 PDT, Yuta Kitamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta Kitamura 2011-06-30 05:39:21 PDT
Some pywebsocket handlers still use old Hixie75 handshake format, while our implementation supports Hixie76 format. Fix them.
Comment 1 Yuta Kitamura 2011-06-30 06:13:31 PDT
Created attachment 99282 [details]
Patch
Comment 2 Kent Tamura 2011-06-30 19:09:00 PDT
Comment on attachment 99282 [details]
Patch

Why have the existing tests worked with the older handshake?
Comment 3 WebKit Review Bot 2011-06-30 19:54:23 PDT
The commit-queue encountered the following flaky tests while processing attachment 99282 [details]:

http/tests/local/blob/send-sliced-data-blob.html bug 63598 (author: kinuko@chromium.org)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Review Bot 2011-06-30 19:56:04 PDT
Comment on attachment 99282 [details]
Patch

Clearing flags on attachment: 99282

Committed r90196: <http://trac.webkit.org/changeset/90196>
Comment 5 WebKit Review Bot 2011-06-30 19:56:08 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Yuta Kitamura 2011-06-30 22:03:26 PDT
(In reply to comment #2)
> (From update of attachment 99282 [details])
> Why have the existing tests worked with the older handshake?

The tests fail before WebSocketChannel checks handshake format of server's response. So they worked regardless of the handshake format.

There is no reason to leave the older handshake in tests, so I wrote this patch. Thank you for your review!
Comment 7 Yuta Kitamura 2011-06-30 22:10:43 PDT
I should have said "the tests finish" instead of "the tests fail". (Failing the connection is expected result for these tests.)