RESOLVED FIXED 63704
WebSocket: Don't use old Hixie75 handshake in pywebsocket handlers 
https://bugs.webkit.org/show_bug.cgi?id=63704
Summary WebSocket: Don't use old Hixie75 handshake in pywebsocket handlers
Yuta Kitamura
Reported 2011-06-30 05:39:21 PDT
Some pywebsocket handlers still use old Hixie75 handshake format, while our implementation supports Hixie76 format. Fix them.
Attachments
Patch (2.58 KB, patch)
2011-06-30 06:13 PDT, Yuta Kitamura 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yuta Kitamura
Comment 1 2011-06-30 06:13:31 PDT
Created attachment 99282 [details] Patch
Kent Tamura
Comment 2 2011-06-30 19:09:00 PDT
Comment on attachment 99282 [details] Patch Why have the existing tests worked with the older handshake?
WebKit Review Bot
Comment 3 2011-06-30 19:54:23 PDT
The commit-queue encountered the following flaky tests while processing attachment 99282 [details]: http/tests/local/blob/send-sliced-data-blob.html bug 63598 (author: kinuko@chromium.org) The commit-queue is continuing to process your patch.
WebKit Review Bot
Comment 4 2011-06-30 19:56:04 PDT
Comment on attachment 99282 [details] Patch Clearing flags on attachment: 99282 Committed r90196: <http://trac.webkit.org/changeset/90196>
WebKit Review Bot
Comment 5 2011-06-30 19:56:08 PDT
All reviewed patches have been landed. Closing bug.
Yuta Kitamura
Comment 6 2011-06-30 22:03:26 PDT
(In reply to comment #2) > (From update of attachment 99282 [details]) > Why have the existing tests worked with the older handshake? The tests fail before WebSocketChannel checks handshake format of server's response. So they worked regardless of the handshake format. There is no reason to leave the older handshake in tests, so I wrote this patch. Thank you for your review!
Yuta Kitamura
Comment 7 2011-06-30 22:10:43 PDT
I should have said "the tests finish" instead of "the tests fail". (Failing the connection is expected result for these tests.)
Note You need to log in before you can comment on or make changes to this bug.