Bug 63700

Summary:

[Chromium] [WebKit API] Implement WebCore::defaultDetailsSummaryText()

Product:

WebKit

Reporter:

Kent Tamura <tkent>

Component:

WebKit API

Assignee:

Kent Tamura <tkent>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, fishd, rniwa, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ec2-cr-linux-02	none
Patch 2	none
Patch for landing	none

Kent Tamura

Reported 2011-06-30 04:17:30 PDT

[Chromium] Implement some localized string functions

Attachments
Patch (3.83 KB, patch) 2011-06-30 04:28 PDT, Kent Tamura	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-02 (1.36 MB, application/zip) 2011-06-30 04:47 PDT, WebKit Review Bot	no flags	Details
Patch 2 (5.71 KB, patch) 2011-06-30 06:02 PDT, Kent Tamura	no flags	Details Formatted Diff Diff
Patch for landing (3.67 KB, patch) 2011-06-30 19:33 PDT, Kent Tamura	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Kent Tamura

Comment 1 2011-06-30 04:28:59 PDT

Created attachment 99275 [details] Patch

WebKit Review Bot

Comment 2 2011-06-30 04:47:19 PDT

Comment on attachment 99275 [details] Patch Attachment 99275 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8960535 New failing tests: fast/html/details-remove-summary-4.html fast/html/details-remove-summary-1.html fast/html/details-no-summary1.html fast/html/details-no-summary3.html fast/html/details-no-summary4.html fast/html/details-remove-summary-1-and-click.html fast/html/details-remove-summary-4-and-click.html fast/html/details-no-summary2.html

WebKit Review Bot

Comment 3 2011-06-30 04:47:24 PDT

Created attachment 99277 [details] Archive of layout-test-results from ec2-cr-linux-02 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-02 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Kent Tamura

Comment 4 2011-06-30 06:02:29 PDT

Created attachment 99280 [details] Patch 2

Darin Fisher (:fishd, Google)

Comment 5 2011-06-30 09:37:20 PDT

Comment on attachment 99280 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=99280&action=review > Source/WebKit/chromium/public/WebLocalizedString.h:38 > + CrashedPlugin, i'm surprised that our port of webkit would ever require CrashedPlugin or MissingPlugin given how we implement those features in chromium.

Kent Tamura

Comment 6 2011-06-30 19:23:22 PDT

Comment on attachment 99280 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=99280&action=review >> Source/WebKit/chromium/public/WebLocalizedString.h:38 >> + CrashedPlugin, > > i'm surprised that our port of webkit would ever require CrashedPlugin or MissingPlugin > given how we implement those features in chromium. Actually, I'm not sure if these strings are used in Chromium except DetailsLabel. I should add only DetailsLabel to avoid unnecessary translations. I'll change the code and land it.

Kent Tamura

Comment 7 2011-06-30 19:33:25 PDT

Created attachment 99418 [details] Patch for landing

WebKit Review Bot

Comment 8 2011-06-30 19:53:12 PDT

Comment on attachment 99418 [details] Patch for landing Clearing flags on attachment: 99418 Committed r90195: <http://trac.webkit.org/changeset/90195>

WebKit Review Bot

Comment 9 2011-06-30 19:53:19 PDT

All reviewed patches have been landed. Closing bug.

Darin Fisher (:fishd, Google)

Comment 10 2011-06-30 21:25:51 PDT

(In reply to comment #6) > Actually, I'm not sure if these strings are used in Chromium except DetailsLabel. > I should add only DetailsLabel to avoid unnecessary translations. > > I'll change the code and land it. ^^^ thanks.

Ryosuke Niwa

Comment 11 2011-07-21 01:15:27 PDT

Committed r91450: <http://trac.webkit.org/changeset/91450>

Note You need to log in before you can comment on or make changes to this bug.