Bug 63679

Summary: [Mac] Use system cursors instead of custom bitmaps where possible
Product: WebKit Reporter: Darin Adler <darin>
Component: PlatformAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, mitz, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Attachments:
Description Flags
Patch
none
Patch mitz: review+

Darin Adler
Reported 2011-06-29 18:35:29 PDT
[Mac] Use system cursors instead of custom bitmaps where possible
Attachments
Patch (18.85 KB, patch)
2011-06-29 18:46 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (19.82 KB, patch)
2011-06-29 21:54 PDT, Darin Adler 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2011-06-29 18:46:26 PDT
Created attachment 99203 [details] Patch
Darin Adler
Comment 2 2011-06-29 18:47:27 PDT
<rdar://problem/8269469>
WebKit Review Bot
Comment 3 2011-06-29 19:15:27 PDT
Comment on attachment 99203 [details] Patch Attachment 99203 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/8959455
mitz
Comment 4 2011-06-29 19:23:05 PDT
Comment on attachment 99203 [details] Patch Looks good but apparently Chromium DumpRenderTree depends on the two files you’re removing.
Darin Adler
Comment 5 2011-06-29 21:34:41 PDT
It’s bizarre that Chromium’s DumpRenderTree uses these files! Maybe Chromium in general is making use of these for cursors?
Darin Adler
Comment 6 2011-06-29 21:54:05 PDT
Created attachment 99235 [details] Patch
mitz
Comment 7 2011-06-29 22:01:33 PDT
Comment on attachment 99235 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99235&action=review > Source/WebCore/ChangeLog:11 > + WebCore/WebCore.gyp/WebCore.gyp: Removed the two now-unused PNG files. Needs a leading star.
Darin Adler
Comment 8 2011-06-29 22:12:34 PDT
Committed r90087: <http://trac.webkit.org/changeset/90087>
Note You need to log in before you can comment on or make changes to this bug.