Summary: | Move XMLDocumentParser to new folder xml/parser/ | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Vicki Pfau <jeffrey+webkit> | ||||||||||||||||
Component: | New Bugs | Assignee: | Vicki Pfau <jeffrey+webkit> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | abarth, dglazkov, gustavo.noronha, gustavo, webkit.review.bot, xan.lopez | ||||||||||||||||
Priority: | P2 | ||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||
Attachments: |
|
Description
Vicki Pfau
2011-06-29 16:01:11 PDT
Created attachment 99168 [details]
Patch
Created attachment 99177 [details]
Patch
Rearranged Xcode project patch so hopefully merging doesn't fail
Comment on attachment 99177 [details] Patch Attachment 99177 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8965199 Comment on attachment 99177 [details] Patch Attachment 99177 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8960352 Created attachment 99188 [details]
Patch
For some reason, the files I moved weren't getting detected. Here's a patch with the files moved properly.
Comment on attachment 99188 [details] Patch Attachment 99188 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8958438 Comment on attachment 99188 [details] Patch Attachment 99188 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/8958462 Created attachment 99332 [details]
Patch
Hopefully won't break this time. I don't know if the changes to the Windows build are correct (XMLDocumentParser is still on the dom config). Furthermore, I moved XMLDocumentParser.h from an "internal" header in the gypi to just another source file.
Comment on attachment 99332 [details] Patch Attachment 99332 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/8963556 Created attachment 99365 [details]
Patch
Comment on attachment 99365 [details] Patch Attachment 99365 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8957851 Created attachment 99385 [details]
Patch
Comment on attachment 99385 [details]
Patch
I presume you tested compile on mac. :)
Comment on attachment 99385 [details] Patch Rejecting attachment 99385 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2 Last 500 characters of output: dom/DocumentFragment.o Source/WebCore/dom/Document.cpp:149: fatal error: XMLDocumentParser.h: No such file or directory compilation terminated. make: *** [out/Debug/obj.target/webcore_remaining/Source/WebCore/dom/Document.o] Error 1 make: *** Waiting for unfinished jobs.... Source/WebCore/dom/DocumentFragment.cpp:30: fatal error: XMLDocumentParser.h: No such file or directory compilation terminated. make: *** [out/Debug/obj.target/webcore_remaining/Source/WebCore/dom/DocumentFragment.o] Error 1 Full output: http://queues.webkit.org/results/8965745 Created attachment 99492 [details]
Patch
added xml/parser to the gyp
Sorry the build system suckage has caused you such pain. Adding a new folder is one of the trickier things (up there with adding a new kind of generated file). Comment on attachment 99492 [details] Patch Clearing flags on attachment: 99492 Committed r90269: <http://trac.webkit.org/changeset/90269> All reviewed patches have been landed. Closing bug. |