Bug 63666

Summary:

Move XMLDocumentParser to new folder xml/parser/

Product:

WebKit

Reporter:

Vicki Pfau <jeffrey+webkit>

Component:

New Bugs

Assignee:

Vicki Pfau <jeffrey+webkit>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, gustavo.noronha, gustavo, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	webkit.review.bot: commit-queue-
Patch	webkit.review.bot: commit-queue-
Patch	gustavo.noronha: commit-queue-
Patch	webkit-ews: commit-queue-
Patch	abarth: review+, webkit.review.bot: commit-queue-
Patch	none

Vicki Pfau

Reported 2011-06-29 16:01:11 PDT

Move XMLDocumentParser to new folder xml/parser/

Attachments
Patch (34.34 KB, patch) 2011-06-29 16:03 PDT, Vicki Pfau	no flags	Details Formatted Diff Diff
Patch (33.73 KB, patch) 2011-06-29 16:27 PDT, Vicki Pfau	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Patch (236.35 KB, patch) 2011-06-29 17:17 PDT, Vicki Pfau	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Patch (237.04 KB, patch) 2011-06-30 10:51 PDT, Vicki Pfau	gustavo.noronha: commit-queue-	Details Formatted Diff Diff
Patch (249.10 KB, patch) 2011-06-30 14:19 PDT, Vicki Pfau	webkit-ews: commit-queue-	Details Formatted Diff Diff
Patch (249.66 KB, patch) 2011-06-30 15:57 PDT, Vicki Pfau	abarth: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Patch (250.11 KB, patch) 2011-07-01 11:34 PDT, Vicki Pfau	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Vicki Pfau

Comment 1 2011-06-29 16:03:28 PDT

Created attachment 99168 [details] Patch

Vicki Pfau

Comment 2 2011-06-29 16:27:47 PDT

Created attachment 99177 [details] Patch Rearranged Xcode project patch so hopefully merging doesn't fail

WebKit Review Bot

Comment 3 2011-06-29 16:34:36 PDT

Comment on attachment 99177 [details] Patch Attachment 99177 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8965199

Early Warning System Bot

Comment 4 2011-06-29 16:45:02 PDT

Comment on attachment 99177 [details] Patch Attachment 99177 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8960352

Vicki Pfau

Comment 5 2011-06-29 17:17:39 PDT

Created attachment 99188 [details] Patch For some reason, the files I moved weren't getting detected. Here's a patch with the files moved properly.

WebKit Review Bot

Comment 6 2011-06-29 17:27:29 PDT

Comment on attachment 99188 [details] Patch Attachment 99188 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8958438

Collabora GTK+ EWS bot

Comment 7 2011-06-29 18:37:24 PDT

Comment on attachment 99188 [details] Patch Attachment 99188 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/8958462

Vicki Pfau

Comment 8 2011-06-30 10:51:47 PDT

Created attachment 99332 [details] Patch Hopefully won't break this time. I don't know if the changes to the Windows build are correct (XMLDocumentParser is still on the dom config). Furthermore, I moved XMLDocumentParser.h from an "internal" header in the gypi to just another source file.

Collabora GTK+ EWS bot

Comment 9 2011-06-30 11:17:21 PDT

Comment on attachment 99332 [details] Patch Attachment 99332 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/8963556

Vicki Pfau

Comment 10 2011-06-30 14:19:47 PDT

Created attachment 99365 [details] Patch

Early Warning System Bot

Comment 11 2011-06-30 14:29:12 PDT

Comment on attachment 99365 [details] Patch Attachment 99365 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8957851

Vicki Pfau

Comment 12 2011-06-30 15:57:44 PDT

Created attachment 99385 [details] Patch

Adam Barth

Comment 13 2011-07-01 00:22:18 PDT

Comment on attachment 99385 [details] Patch I presume you tested compile on mac. :)

WebKit Review Bot

Comment 14 2011-07-01 01:00:51 PDT

Comment on attachment 99385 [details] Patch Rejecting attachment 99385 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2 Last 500 characters of output: dom/DocumentFragment.o Source/WebCore/dom/Document.cpp:149: fatal error: XMLDocumentParser.h: No such file or directory compilation terminated. make: *** [out/Debug/obj.target/webcore_remaining/Source/WebCore/dom/Document.o] Error 1 make: *** Waiting for unfinished jobs.... Source/WebCore/dom/DocumentFragment.cpp:30: fatal error: XMLDocumentParser.h: No such file or directory compilation terminated. make: *** [out/Debug/obj.target/webcore_remaining/Source/WebCore/dom/DocumentFragment.o] Error 1 Full output: http://queues.webkit.org/results/8965745

Vicki Pfau

Comment 15 2011-07-01 11:34:21 PDT

Created attachment 99492 [details] Patch added xml/parser to the gyp

Adam Barth

Comment 16 2011-07-01 11:35:31 PDT

Sorry the build system suckage has caused you such pain. Adding a new folder is one of the trickier things (up there with adding a new kind of generated file).

WebKit Review Bot

Comment 17 2011-07-01 13:09:03 PDT

Comment on attachment 99492 [details] Patch Clearing flags on attachment: 99492 Committed r90269: <http://trac.webkit.org/changeset/90269>

WebKit Review Bot

Comment 18 2011-07-01 13:09:11 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.