Bug 63661

Summary: Make port/config.py mockable for easier unit testing
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 63501    
Attachments:
Description Flags
Patch abarth: review+, eric: commit-queue-

Description Eric Seidel (no email) 2011-06-29 14:40:13 PDT 
Make port/config.py mockable for easier unit testing
Comment 1 Eric Seidel (no email) 2011-06-29 14:42:12 PDT 
Created attachment 99154 [details]
Patch
Comment 2 Adam Barth 2011-06-29 14:45:37 PDT 
Comment on attachment 99154 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99154&action=review

> Tools/Scripts/webkitpy/common/system/filesystem.py:62
> +        import sys

Why not import sys at the top of the file?
Comment 3 Eric Seidel (no email) 2011-06-29 14:46:09 PDT 
Comment on attachment 99154 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99154&action=review

>> Tools/Scripts/webkitpy/common/system/filesystem.py:62
>> +        import sys
> 
> Why not import sys at the top of the file?

Sure, happy to move it.
Comment 4 Eric Seidel (no email) 2011-06-29 14:49:25 PDT 
Sigh.  This landed as http://trac.webkit.org/changeset/90050.  Silly git.
Comment 5 Dirk Pranke 2011-06-29 14:50:27 PDT 
Looks fine to me also ...
Comment 6 Eric Seidel (no email) 2011-06-29 14:51:00 PDT 
(In reply to comment #5)
> Looks fine to me also ...

Thanks for looking!
Comment 7 Eric Seidel (no email) 2011-06-29 14:59:45 PDT 
Fixed in http://trac.webkit.org/changeset/90051.