Bug 63660

Summary: Only enable TestWebKitAPI on bots on win and mac-snowleopard
Product: WebKit Reporter: Dmitry Lomov <dslomov>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, dslomov, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
The fix
aroben: review+, aroben: commit-queue-
CR feedback none

Dmitry Lomov
Reported 2011-06-29 14:31:26 PDT
WebKit2 does not support Leopard
Attachments
The fix (1.86 KB, patch)
2011-06-29 14:39 PDT, Dmitry Lomov 		aroben: review+
aroben: commit-queue-
DetailsFormatted DiffDiff
CR feedback (2.28 KB, patch)
2011-06-29 17:05 PDT, Dmitry Lomov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dmitry Lomov
Comment 1 2011-06-29 14:39:46 PDT
Created attachment 99153 [details] The fix
Adam Roben (:aroben)
Comment 2 2011-06-29 14:44:25 PDT
Comment on attachment 99153 [details] The fix View in context: https://bugs.webkit.org/attachment.cgi?id=99153&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:539 > + if configuration == "debug" and (platform == 'mac-snowleopard' or platform == 'win'): It would be nice if we didn't have to change this line of code once we have a mac-lion bot. The mixture of single- and double-quotes here is strange. I'd write the second part as: platform in ('mac-snowleopard, 'win') > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:562 > + if configuration == "debug" and (platform == 'mac-snowleopard' or platform == 'win'): Same comments as above.
Dmitry Lomov
Comment 3 2011-06-29 17:05:57 PDT
Created attachment 99185 [details] CR feedback
WebKit Review Bot
Comment 4 2011-06-30 05:55:51 PDT
Comment on attachment 99185 [details] CR feedback Clearing flags on attachment: 99185 Committed r90108: <http://trac.webkit.org/changeset/90108>
WebKit Review Bot
Comment 5 2011-06-30 05:55:56 PDT
All reviewed patches have been landed. Closing bug.
Adam Roben (:aroben)
Comment 6 2011-06-30 06:00:46 PDT
Buildbot master restarted.
Note You need to log in before you can comment on or make changes to this bug.