| Summary: | Switch offsetFromContainer and related to to new layout types | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Emil A Eklund <eae> | ||||||||||
| Component: | Layout and Rendering | Assignee: | Emil A Eklund <eae> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | eric, leviw, webkit.review.bot | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 63567 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Emil A Eklund
2011-06-29 14:29:06 PDT
Created attachment 99156 [details]
Patch
Created attachment 99363 [details]
Patch
Comment on attachment 99363 [details]
Patch
He's making you do all the hard ones. Same fears about it not being clear when it's OK to call these roudning methods and if they'll do anything in the float world.
Comment on attachment 99363 [details]
Patch
OK.
Comment on attachment 99363 [details] Patch Rejecting attachment 99363 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 2 Last 500 characters of output: 7ec0184a9c980a8e2331273567200b5d59ad76fd r90485 = f78dec6e464c457097927d81bdecf1728a8d1c4f Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/8995112 Created attachment 99902 [details]
Patch for landing
Comment on attachment 99902 [details] Patch for landing Rejecting attachment 99902 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2 Last 500 characters of output: 268f45cc-cd09-0410-ab3c-d52691b4dbfc M Tools/Scripts/webkitpy/common/config/committers.py M Tools/ChangeLog r90519 = c331ee11f781cbef19b6e2428504514bdbcd18ef (refs/remotes/origin/master) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/8987885 Created attachment 99912 [details]
Patch for landing
Comment on attachment 99912 [details] Patch for landing Clearing flags on attachment: 99912 Committed r90525: <http://trac.webkit.org/changeset/90525> All reviewed patches have been landed. Closing bug. |