RESOLVED FIXED 63659
Switch offsetFromContainer and related to to new layout types 
https://bugs.webkit.org/show_bug.cgi?id=63659
Summary Switch offsetFromContainer and related to to new layout types
Emil A Eklund
Reported 2011-06-29 14:29:06 PDT
Convert offsetFromContainer and related methods to new layout types.
Attachments
Patch (16.95 KB, patch)
2011-06-29 14:52 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch (16.98 KB, patch)
2011-06-30 13:51 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch for landing (14.74 KB, patch)
2011-07-06 17:04 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch for landing (16.83 KB, patch)
2011-07-06 18:50 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2011-06-29 14:52:06 PDT
Created attachment 99156 [details] Patch
Emil A Eklund
Comment 2 2011-06-30 13:51:28 PDT
Created attachment 99363 [details] Patch
Eric Seidel (no email)
Comment 3 2011-06-30 13:54:20 PDT
Comment on attachment 99363 [details] Patch He's making you do all the hard ones. Same fears about it not being clear when it's OK to call these roudning methods and if they'll do anything in the float world.
Eric Seidel (no email)
Comment 4 2011-07-06 13:01:39 PDT
Comment on attachment 99363 [details] Patch OK.
WebKit Review Bot
Comment 5 2011-07-06 13:22:00 PDT
Comment on attachment 99363 [details] Patch Rejecting attachment 99363 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 2 Last 500 characters of output: 7ec0184a9c980a8e2331273567200b5d59ad76fd r90485 = f78dec6e464c457097927d81bdecf1728a8d1c4f Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/8995112
Emil A Eklund
Comment 6 2011-07-06 17:04:53 PDT
Created attachment 99902 [details] Patch for landing
WebKit Review Bot
Comment 7 2011-07-06 17:37:32 PDT
Comment on attachment 99902 [details] Patch for landing Rejecting attachment 99902 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2 Last 500 characters of output: 268f45cc-cd09-0410-ab3c-d52691b4dbfc M Tools/Scripts/webkitpy/common/config/committers.py M Tools/ChangeLog r90519 = c331ee11f781cbef19b6e2428504514bdbcd18ef (refs/remotes/origin/master) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/8987885
Emil A Eklund
Comment 8 2011-07-06 18:50:37 PDT
Created attachment 99912 [details] Patch for landing
WebKit Review Bot
Comment 9 2011-07-06 19:32:40 PDT
Comment on attachment 99912 [details] Patch for landing Clearing flags on attachment: 99912 Committed r90525: <http://trac.webkit.org/changeset/90525>
WebKit Review Bot
Comment 10 2011-07-06 19:32:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.