Bug 63657

Summary: Remove ElementWithPseudoId, since now an Element can store it all by itself.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: New BugsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, morrita, rafael.lobo, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 58584    
Attachments:
Description Flags
Patch
none
Patch for landing none

Dimitri Glazkov (Google)
Reported 2011-06-29 14:16:36 PDT
Remove ElementWithPseudoId, since now an Element can store it all by itself.
Attachments
Patch (19.19 KB, patch)
2011-06-29 14:18 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Patch for landing (19.21 KB, patch)
2011-06-29 16:23 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-06-29 14:18:09 PDT
Created attachment 99148 [details] Patch
Kent Tamura
Comment 2 2011-06-29 14:55:06 PDT
Comment on attachment 99148 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99148&action=review > Source/WebCore/html/ValidationMessage.cpp:135 > host->ensureShadowRoot()->appendChild(m_bubble.get(), ec); > nit: We had better have ASSERT(!ec);
Dimitri Glazkov (Google)
Comment 3 2011-06-29 16:23:04 PDT
Created attachment 99176 [details] Patch for landing
WebKit Review Bot
Comment 4 2011-06-29 17:03:49 PDT
Comment on attachment 99176 [details] Patch for landing Clearing flags on attachment: 99176 Committed r90071: <http://trac.webkit.org/changeset/90071>
WebKit Review Bot
Comment 5 2011-06-29 17:03:54 PDT
All reviewed patches have been landed. Closing bug.
Rafael Brandao
Comment 6 2011-06-30 13:35:11 PDT
Got this when I was building: Reading [...]/WebKit/Source/WebCore/WebCore.pro [[...]/WebKit/WebKitBuild/Release/WebCore] WARNING: Failure to find: html/shadow/ElementWithPseudoId.h Perhaps this patch caused this? It's building though, just an annoying warning.
Rafael Brandao
Comment 7 2011-06-30 13:45:59 PDT
(In reply to comment #6) > Got this when I was building: > > Reading [...]/WebKit/Source/WebCore/WebCore.pro [[...]/WebKit/WebKitBuild/Release/WebCore] > WARNING: Failure to find: html/shadow/ElementWithPseudoId.h > > Perhaps this patch caused this? It's building though, just an annoying warning. It'll be a quick fix, I'll handle that.
Note You need to log in before you can comment on or make changes to this bug.