Bug 63655

Summary: Switch computeWidth and computeHeight functions to new layout types
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: eae, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 63567    
Attachments:
Description Flags
Patch
none
Patch for landing none

Levi Weintraub
Reported 2011-06-29 14:07:02 PDT
More conversion fun!
Attachments
Patch (47.67 KB, patch)
2011-06-29 14:51 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Patch for landing (47.26 KB, patch)
2011-06-29 16:17 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2011-06-29 14:51:29 PDT
Created attachment 99155 [details] Patch
Eric Seidel (no email)
Comment 2 2011-06-29 14:59:25 PDT
Comment on attachment 99155 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99155&action=review > Source/WebCore/rendering/LayoutTypes.h:44 > +#define LAYOUT_MAX INT_MAX I guess we could use numeric_limits<LayoutUnit>::max() in the callsites. I'm not sure that's any better though.
Levi Weintraub
Comment 3 2011-06-29 15:01:27 PDT
(In reply to comment #2) > (From update of attachment 99155 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=99155&action=review > > > Source/WebCore/rendering/LayoutTypes.h:44 > > +#define LAYOUT_MAX INT_MAX > > I guess we could use numeric_limits<LayoutUnit>::max() in the callsites. I'm not sure that's any better though. I like that way more actually. I'll change it before landing.
Darin Adler
Comment 4 2011-06-29 15:16:38 PDT
Comment on attachment 99155 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99155&action=review >>> Source/WebCore/rendering/LayoutTypes.h:44 >>> +#define LAYOUT_MAX INT_MAX >> >> I guess we could use numeric_limits<LayoutUnit>::max() in the callsites. I'm not sure that's any better though. > > I like that way more actually. I'll change it before landing. Good. I think it’s much better!
Levi Weintraub
Comment 5 2011-06-29 16:17:14 PDT
Created attachment 99173 [details] Patch for landing
WebKit Review Bot
Comment 6 2011-06-29 17:00:02 PDT
Comment on attachment 99173 [details] Patch for landing Clearing flags on attachment: 99173 Committed r90069: <http://trac.webkit.org/changeset/90069>
WebKit Review Bot
Comment 7 2011-06-29 17:00:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.