Summary: | Switch computeWidth and computeHeight functions to new layout types | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Levi Weintraub <leviw> | ||||||
Component: | Layout and Rendering | Assignee: | Levi Weintraub <leviw> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eae, eric, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 63567 | ||||||||
Attachments: |
|
Description
Levi Weintraub
2011-06-29 14:07:02 PDT
Created attachment 99155 [details]
Patch
Comment on attachment 99155 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99155&action=review > Source/WebCore/rendering/LayoutTypes.h:44 > +#define LAYOUT_MAX INT_MAX I guess we could use numeric_limits<LayoutUnit>::max() in the callsites. I'm not sure that's any better though. (In reply to comment #2) > (From update of attachment 99155 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=99155&action=review > > > Source/WebCore/rendering/LayoutTypes.h:44 > > +#define LAYOUT_MAX INT_MAX > > I guess we could use numeric_limits<LayoutUnit>::max() in the callsites. I'm not sure that's any better though. I like that way more actually. I'll change it before landing. Comment on attachment 99155 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99155&action=review >>> Source/WebCore/rendering/LayoutTypes.h:44 >>> +#define LAYOUT_MAX INT_MAX >> >> I guess we could use numeric_limits<LayoutUnit>::max() in the callsites. I'm not sure that's any better though. > > I like that way more actually. I'll change it before landing. Good. I think it’s much better! Created attachment 99173 [details]
Patch for landing
Comment on attachment 99173 [details] Patch for landing Clearing flags on attachment: 99173 Committed r90069: <http://trac.webkit.org/changeset/90069> All reviewed patches have been landed. Closing bug. |