Bug 63645

Summary: Switch paint to new layout types
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: eae, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 63567    
Attachments:
Description Flags
Patch none

Description Levi Weintraub 2011-06-29 12:17:32 PDT 
Converting the vanilla paint method to the new layout types.
Comment 1 Levi Weintraub 2011-06-29 12:24:58 PDT 
Created attachment 99127 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-06-29 13:12:49 PDT 
Comment on attachment 99127 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99127&action=review

LGTM.

> Source/WebCore/rendering/svg/RenderSVGText.h:55
> +    virtual void paint(PaintInfo&, const LayoutPoint&);

What does the point mean in this call?
Comment 3 Levi Weintraub 2011-06-29 13:50:51 PDT 
Comment on attachment 99127 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99127&action=review

Thanks for the review!

>> Source/WebCore/rendering/svg/RenderSVGText.h:55
>> +    virtual void paint(PaintInfo&, const LayoutPoint&);
> 
> What does the point mean in this call?

In SVG it means essentially nothing, but exists only to keep the signature consistent. Only RenderSVGRoot uses it to set up the paint context :)
Comment 4 Eric Seidel (no email) 2011-06-29 13:53:27 PDT 
I meant in general.  All of those paint() calls could use some documentation of what LayoutPoint means.
Comment 5 WebKit Review Bot 2011-06-29 14:33:25 PDT 
Comment on attachment 99127 [details]
Patch

Clearing flags on attachment: 99127

Committed r90048: <http://trac.webkit.org/changeset/90048>
Comment 6 WebKit Review Bot 2011-06-29 14:33:30 PDT 
All reviewed patches have been landed.  Closing bug.