RESOLVED FIXED 63645
Switch paint to new layout types 
https://bugs.webkit.org/show_bug.cgi?id=63645
Summary Switch paint to new layout types
Levi Weintraub
Reported 2011-06-29 12:17:32 PDT
Converting the vanilla paint method to the new layout types.
Attachments
Patch (47.90 KB, patch)
2011-06-29 12:24 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2011-06-29 12:24:58 PDT
Created attachment 99127 [details] Patch
Eric Seidel (no email)
Comment 2 2011-06-29 13:12:49 PDT
Comment on attachment 99127 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99127&action=review LGTM. > Source/WebCore/rendering/svg/RenderSVGText.h:55 > + virtual void paint(PaintInfo&, const LayoutPoint&); What does the point mean in this call?
Levi Weintraub
Comment 3 2011-06-29 13:50:51 PDT
Comment on attachment 99127 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99127&action=review Thanks for the review! >> Source/WebCore/rendering/svg/RenderSVGText.h:55 >> + virtual void paint(PaintInfo&, const LayoutPoint&); > > What does the point mean in this call? In SVG it means essentially nothing, but exists only to keep the signature consistent. Only RenderSVGRoot uses it to set up the paint context :)
Eric Seidel (no email)
Comment 4 2011-06-29 13:53:27 PDT
I meant in general. All of those paint() calls could use some documentation of what LayoutPoint means.
WebKit Review Bot
Comment 5 2011-06-29 14:33:25 PDT
Comment on attachment 99127 [details] Patch Clearing flags on attachment: 99127 Committed r90048: <http://trac.webkit.org/changeset/90048>
WebKit Review Bot
Comment 6 2011-06-29 14:33:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.