Bug 63645 - Switch paint to new layout types
Summary: Switch paint to new layout types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks: 63567
  Show dependency tree / graph
 
Reported: 2011-06-29 12:17 PDT by Levi Weintraub
Modified: 2011-06-29 14:33 PDT (History)
3 users (show)

See Also:

Attachments
Patch (47.90 KB, patch)
2011-06-29 12:24 PDT, Levi Weintraub 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2011-06-29 12:17:32 PDT 
Converting the vanilla paint method to the new layout types.
Comment 1 Levi Weintraub 2011-06-29 12:24:58 PDT 
Created attachment 99127 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-06-29 13:12:49 PDT 
Comment on attachment 99127 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99127&action=review

LGTM.

> Source/WebCore/rendering/svg/RenderSVGText.h:55
> +    virtual void paint(PaintInfo&, const LayoutPoint&);

What does the point mean in this call?
Comment 3 Levi Weintraub 2011-06-29 13:50:51 PDT 
Comment on attachment 99127 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99127&action=review

Thanks for the review!

>> Source/WebCore/rendering/svg/RenderSVGText.h:55
>> +    virtual void paint(PaintInfo&, const LayoutPoint&);
> 
> What does the point mean in this call?

In SVG it means essentially nothing, but exists only to keep the signature consistent. Only RenderSVGRoot uses it to set up the paint context :)
Comment 4 Eric Seidel (no email) 2011-06-29 13:53:27 PDT 
I meant in general.  All of those paint() calls could use some documentation of what LayoutPoint means.
Comment 5 WebKit Review Bot 2011-06-29 14:33:25 PDT 
Comment on attachment 99127 [details]
Patch

Clearing flags on attachment: 99127

Committed r90048: <http://trac.webkit.org/changeset/90048>
Comment 6 WebKit Review Bot 2011-06-29 14:33:30 PDT 
All reviewed patches have been landed.  Closing bug.