Bug 63641

Summary: Convert uses of computeLengthIntForLength to computeLength<Length>()
Product: WebKit Reporter: Luke Macpherson <macpherson>
Component: New BugsAssignee: Luke Macpherson <macpherson>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Luke Macpherson
Reported 2011-06-29 12:02:25 PDT
Convert uses of computeLengthIntForLength to computeLength<Length>()
Attachments
Patch (7.66 KB, patch)
2011-06-29 12:04 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Patch (7.66 KB, patch)
2011-06-29 13:30 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Luke Macpherson
Comment 1 2011-06-29 12:04:24 PDT
Created attachment 99122 [details] Patch
Darin Adler
Comment 2 2011-06-29 12:08:44 PDT
Comment on attachment 99122 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99122&action=review > Source/WebCore/css/CSSStyleSelector.cpp:4054 > + lineHeight = primitiveValue->computeLength<Length>(style(), m_rootElementStyle, multiplier); Extra space here after one of the commas.
Luke Macpherson
Comment 3 2011-06-29 13:30:16 PDT
Created attachment 99138 [details] Patch
WebKit Review Bot
Comment 4 2011-06-29 14:26:14 PDT
Comment on attachment 99138 [details] Patch Clearing flags on attachment: 99138 Committed r90045: <http://trac.webkit.org/changeset/90045>
WebKit Review Bot
Comment 5 2011-06-29 14:26:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.