Bug 63612

Summary: implement WebEditorClient::setInputMethodState()
Product: WebKit Reporter: SangYong Park <sy302.park>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: ap
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch morrita: review-, webkit-ews: commit-queue-

SangYong Park
Reported 2011-06-29 01:55:13 PDT
implement WebEditorClient::setInputMethodState()
Attachments
patch (5.87 KB, patch)
2011-06-29 03:04 PDT, SangYong Park 		morrita: review-
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
SangYong Park
Comment 1 2011-06-29 03:04:45 PDT
Created attachment 99062 [details] patch
Early Warning System Bot
Comment 2 2011-06-29 03:13:00 PDT
Comment on attachment 99062 [details] patch Attachment 99062 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8963030
Alexey Proskuryakov
Comment 3 2011-06-29 10:27:22 PDT
Is it really necessary? I hoped that we could get rid of it in WebKit2.
Hajime Morrita
Comment 4 2011-07-04 23:55:22 PDT
Comment on attachment 99062 [details] patch r- per the ews error. It looks that Qt WK1 depends on this. so Qt WK2 might.
Alexey Proskuryakov
Comment 5 2011-07-05 00:02:49 PDT
That's not a good reason for Qt WebKit2 to depend on it. Other ports have the same logic, but implemented without relying on this client call.
Note You need to log in before you can comment on or make changes to this bug.