Bug 63600

Summary:

Add ENABLE(COMPONENT_MODEL) flag to WebKit

Product:

WebKit

Reporter:

Dimitri Glazkov (Google) <dglazkov>

Component:

DOM

Assignee:

Dimitri Glazkov (Google) <dglazkov>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

cmarcelo, dominicc, gustavo.noronha, gustavo, morrita, rolandsteiner, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

63606

Attachments:

Description	Flags
Cook on bots.	none
Cook more.	none
Bake, dammit.	none
Baka-baka-baka.	none
Bake moar.	none

Dimitri Glazkov (Google)

Reported 2011-06-28 20:08:28 PDT

We need this to allow disabling/enabling the API.

Attachments
Cook on bots. (62.12 KB, patch) 2011-09-02 16:43 PDT, Dimitri Glazkov (Google)	no flags	Details Formatted Diff Diff
Cook more. (62.01 KB, patch) 2011-09-04 10:03 PDT, Dimitri Glazkov (Google)	no flags	Details Formatted Diff Diff
Bake, dammit. (67.18 KB, patch) 2011-09-06 14:25 PDT, Dimitri Glazkov (Google)	no flags	Details Formatted Diff Diff
Baka-baka-baka. (67.17 KB, patch) 2011-09-07 10:02 PDT, Dimitri Glazkov (Google)	no flags	Details Formatted Diff Diff
Bake moar. (67.23 KB, patch) 2011-09-07 11:58 PDT, Dimitri Glazkov (Google)	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Hajime Morrita

Comment 1 2011-06-28 20:37:19 PDT

We can add an Settings flag at the same time.

Dimitri Glazkov (Google)

Comment 2 2011-09-02 16:43:48 PDT

Created attachment 106223 [details] Cook on bots.

WebKit Review Bot

Comment 3 2011-09-02 20:02:39 PDT

Comment on attachment 106223 [details] Cook on bots. Attachment 106223 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/9583813

Collabora GTK+ EWS bot

Comment 4 2011-09-03 01:40:57 PDT

Comment on attachment 106223 [details] Cook on bots. Attachment 106223 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/9589147

Dimitri Glazkov (Google)

Comment 5 2011-09-04 10:03:56 PDT

Created attachment 106287 [details] Cook more.

Collabora GTK+ EWS bot

Comment 6 2011-09-04 10:23:22 PDT

Comment on attachment 106287 [details] Cook more. Attachment 106287 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/9591367

Dimitri Glazkov (Google)

Comment 7 2011-09-06 14:25:49 PDT

Created attachment 106486 [details] Bake, dammit.

Dimitri Glazkov (Google)

Comment 8 2011-09-07 10:02:15 PDT

Created attachment 106594 [details] Baka-baka-baka.

Early Warning System Bot

Comment 9 2011-09-07 10:19:25 PDT

Comment on attachment 106594 [details] Baka-baka-baka. Attachment 106594 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9602646

Collabora GTK+ EWS bot

Comment 10 2011-09-07 10:25:35 PDT

Comment on attachment 106594 [details] Baka-baka-baka. Attachment 106594 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/9602649

Dimitri Glazkov (Google)

Comment 11 2011-09-07 11:58:06 PDT

Created attachment 106617 [details] Bake moar.

Roland Steiner

Comment 12 2011-11-20 21:16:59 PST

Shouldn't this better be 2 patches - one just for the flag, and one for the ShadowRoot JS stuff + tests?

Dimitri Glazkov (Google)

Comment 13 2011-11-21 09:06:23 PST

(In reply to comment #12) > Shouldn't this better be 2 patches - one just for the flag, and one for the ShadowRoot JS stuff + tests? Yup.

Dimitri Glazkov (Google)

Comment 14 2012-01-06 12:57:25 PST

We're not going to have a flag like this. Rather, probably a set of flags.

Note You need to log in before you can comment on or make changes to this bug.