Bug 63593

Summary: IndexedDB: Prepare for running layout tests with LevelDB
Product: WebKit Reporter: Hans Wennborg <hans>
Component: New BugsAssignee: Hans Wennborg <hans>
Status: RESOLVED FIXED    
Severity: Normal CC: dgrogan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch tony: review+

Hans Wennborg
Reported 2011-06-28 18:20:52 PDT
IndexedDB: Prepare for running layout tests with LevelDB
Attachments
Patch (11.41 KB, patch)
2011-06-28 18:26 PDT, Hans Wennborg 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hans Wennborg
Comment 1 2011-06-28 18:26:14 PDT
Created attachment 99021 [details] Patch
David Grogan
Comment 2 2011-06-29 15:26:27 PDT
Comment on attachment 99021 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99021&action=review LGTM > Source/WebCore/ChangeLog:8 > + Migration of data from SQLite to LevelDB must be done before the From an IM convo with hans: the problem occurs when we first use leveldb, then sqlite, and then leveldb again.. which happens in the case of layout tests
Tony Chang
Comment 3 2011-06-30 11:06:14 PDT
Comment on attachment 99021 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99021&action=review >> Source/WebCore/ChangeLog:8 >> + Migration of data from SQLite to LevelDB must be done before the > > From an IM convo with hans: > the problem occurs when we first use leveldb, then sqlite, and then leveldb again.. which happens in the case of layout tests Would be nice to include this in the ChangeLog description. > Source/WebCore/storage/IDBFactoryBackendImpl.cpp:110 > + (void)migrationSucceeded; // FIXME: When migration is actually implemented, we need error handling here. Nit: UNUSED_PARAM(migrationSucceeded)
Hans Wennborg
Comment 4 2011-06-30 11:33:11 PDT
Committed r90137: <http://trac.webkit.org/changeset/90137>
Note You need to log in before you can comment on or make changes to this bug.